fbpx

PHP Code Review Guidelines

Questions to consider while reviewing code:

  1. Is the code readable as written?  Does it require additional comments, better naming, or general refactoring to be easily understandable?  Does the code generally conform to the style of coding for the project?
  2. Does each function contain a (very) brief comment describing functionality, inputs, and outputs?
  3. Does new code keep business logic away from presentation code?
  4. Is identical functionality repeated multiple places in the code base?
  5. Are there any code blocks that should be abstracted into functions or classes for maintainability?
  6. Are there any hard coded constants that could possible change in the future?
  7. Are all reasonable error conditions handled?

Thanks to TCG for this